Nick Clifton nickc@redhat.com
Fri Jun 12 13:56:00 GMT 2009

• Previous message (by thread): [PATCH] Fix readelf -sI (or -a)
• Next message (by thread): [PATCH][ARM]. Fix a 64-bit portability bug in cortex_a8_erratum_scan.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi John,

>> +	  free (gnubuckets);
>> +	  if (do_using_dynamic)
>> +	    return 0;
>> +	  gnubuckets = NULL;
> 
> It would be safer to set gnubuckets to NULL immediately after free()ing.
> Allowing 'return' between "free (gnubuckets);" and "gnubuckets = NULL;"
> allows bugs to propagate, and possibly making future maintenance more costly.

A fair point.  It would also be better to move the return to after the 
"ngnubuckets = 0" statement, so I have done that and checked in the 
patch with this changelog entry.

Cheers
   Nick

binutils/ChangeLog
2009-06-12  John Reiser  <jreiser@BitWagon.com>

	* readelf.c (process_symbol_table): Set gnubuckets to NULL after
	freeing it and before returning.

---

• Previous message (by thread): [PATCH] Fix readelf -sI (or -a)
• Next message (by thread): [PATCH][ARM]. Fix a 64-bit portability bug in cortex_a8_erratum_scan.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list