Nick Clifton nickc@redhat.com
Fri May 8 15:36:00 GMT 2009

• Previous message (by thread): [patch] Add plugin support for bfd
• Next message (by thread): [patch] Add plugin support for bfd
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Rafael,

> binutils/
> 2009-05-08  Rafael Avila de Espindola  <espindola@google.com>
> 
> 	* ar.c: Include plugin.h.
> 	(main): Handle the --plugin option.
> 	* nm.c: Include plugin.h.
> 	(OPTION_PLUGIN): New.
> 	(long_options): Add plugin.
> 	(main): Handle OPTION_PLUGIN.

A couple of points with this part of the patch:

   * You should document the new command line switches supported by nm 
and ar in the binutils/doc/binutils.texi file.  Plus the switches should 
be mentioned briefly in the --help output of these two tools.

   * You should mention the new feature in the binutils/NEWS file.

   * Ideally you should add a test or two to the binutils testsuite to 
check the plugin support.  This might be kind of tricky to write however...

Cheers
   Nick

---

• Previous message (by thread): [patch] Add plugin support for bfd
• Next message (by thread): [patch] Add plugin support for bfd
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list