Dave Korn dave.korn.cygwin@googlemail.com
Sun May 10 23:24:00 GMT 2009

• Previous message (by thread): [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
• Next message (by thread): [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Mike Frysinger wrote:
> On Saturday 09 May 2009 23:03:18 Masaki Muranaka wrote:
>> There are some redundant ATTRIBUTE_UNUSEDs in elf32-bfin.c
>> These may be harmless but should be fixed for trusted code.
> 
> sorry, but how are they redundant ?
> -mike

  It looks to me like they are redundant because the argument in question is,
in fact, used, after all, probably as a result of the code evolving since the
prototype for the function was first written.  Given that we have -Werror,
surely if this compiles it must be correct?

    cheers,
      DaveK

---

• Previous message (by thread): [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
• Next message (by thread): [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list