Home Original page

[vms/committed] Tiny cleanup

Tristan Gingold gingold@adacore.com
Wed Aug 4 08:43:00 GMT 2010 
Hi,

this patch renames a function for consistency, remove a commented out function.
It also fixes the result of get_symbol_info for unknown section.

Tristan.

bfd/
2010-08-04  Tristan Gingold  <gingold@adacore.com>

	* vms-alpha.c (alpha_vms_add_lw_fixup): Renamed to ...
	(alpha_vms_add_fixup_lr): ... this for consistency.
	(alpha_vms_add_qw_fixup): Removed.
	Fix some comments.
	(vms_get_symbol_info): Adjust type for unknown sections.

Index: vms-alpha.c
===================================================================
RCS file: /cvs/src/src/bfd/vms-alpha.c,v
retrieving revision 1.32
diff -c -r1.32 vms-alpha.c
*** vms-alpha.c 4 Aug 2010 07:50:40 -0000       1.32
--- vms-alpha.c 4 Aug 2010 08:01:38 -0000
***************
*** 376,385 ****
  static void alpha_vms_add_fixup_ca (struct bfd_link_info *, bfd *, bfd *);
  static void alpha_vms_add_fixup_qr (struct bfd_link_info *, bfd *, bfd *,
                                      bfd_vma);
  static void alpha_vms_add_lw_reloc (struct bfd_link_info *info);
  static void alpha_vms_add_qw_reloc (struct bfd_link_info *info);
- static void alpha_vms_add_lw_fixup (struct bfd_link_info *, unsigned int,
-                                     bfd_vma);
  
  struct vector_type
  {
--- 376,385 ----
  static void alpha_vms_add_fixup_ca (struct bfd_link_info *, bfd *, bfd *);
  static void alpha_vms_add_fixup_qr (struct bfd_link_info *, bfd *, bfd *,
                                      bfd_vma);
+ static void alpha_vms_add_fixup_lr (struct bfd_link_info *, unsigned int,
+                                     bfd_vma);
  static void alpha_vms_add_lw_reloc (struct bfd_link_info *info);
  static void alpha_vms_add_qw_reloc (struct bfd_link_info *info);
  
  struct vector_type
  {
***************
*** 1799,1805 ****
              }
            else if (rel1 & RELC_SHR_BASE)
              {
!               alpha_vms_add_lw_fixup (info, rel1 & RELC_MASK, op1);
                rel1 = RELC_NONE;
              }
            if (rel1 != RELC_NONE)
--- 1799,1805 ----
              }
            else if (rel1 & RELC_SHR_BASE)
              {
!               alpha_vms_add_fixup_lr (info, rel1 & RELC_MASK, op1);
                rel1 = RELC_NONE;
              }
            if (rel1 != RELC_NONE)
***************
*** 8051,8072 ****
  }
  
  static void
! alpha_vms_add_lw_fixup (struct bfd_link_info *info ATTRIBUTE_UNUSED,
                          unsigned int shr ATTRIBUTE_UNUSED,
                          bfd_vma vec ATTRIBUTE_UNUSED)
  {
    abort ();
  }
  
! #if 0
! static void
! alpha_vms_add_qw_fixup (struct bfd_link_info *info ATTRIBUTE_UNUSED,
!                         unsigned int shr ATTRIBUTE_UNUSED,
!                         bfd_vma vec ATTRIBUTE_UNUSED)
! {
!   abort ();
! }
! #endif
  
  static void
  alpha_vms_add_lw_reloc (struct bfd_link_info *info ATTRIBUTE_UNUSED)
--- 8051,8064 ----
  }
  
  static void
! alpha_vms_add_fixup_lr (struct bfd_link_info *info ATTRIBUTE_UNUSED,
                          unsigned int shr ATTRIBUTE_UNUSED,
                          bfd_vma vec ATTRIBUTE_UNUSED)
  {
    abort ();
  }
  
! /* Add relocation.  FIXME: Not yet emitted.  */
  
  static void
  alpha_vms_add_lw_reloc (struct bfd_link_info *info ATTRIBUTE_UNUSED)
***************
*** 8529,8536 ****
            bfd_putl32 (0, content + off + 4);
            off += 8;
          }
- 
-       /* CA fixups.  */
      }
  
    return TRUE;
--- 8521,8526 ----
***************
*** 9115,9121 ****
    else if (bfd_get_section_flags (abfd, sec) & SEC_ALLOC)
      ret->type = 'B';
    else
!     ret->type = '-';
  
    if (ret->type != 'U')
      ret->value = symbol->value + symbol->section->vma;
--- 9105,9111 ----
    else if (bfd_get_section_flags (abfd, sec) & SEC_ALLOC)
      ret->type = 'B';
    else
!     ret->type = '?';
  
    if (ret->type != 'U')
      ret->value = symbol->value + symbol->section->vma;
More information about the Binutils mailing list