Home Original page

[gold patch 2/3] Support for incremental linking: write incremental got_plt info

Tom Tromey tromey@redhat.com
Thu Aug 12 17:34:00 GMT 2010 
>>>>> "Ian" == Ian Lance Taylor <iant@google.com> writes:

Ian> This is interesting, because it means that if you change the values qof
Ian> the GOT_TYPE_ enums in the gold source code, existing incremental input
Ian> files will fail in surprising ways.  That is, it makes the specific enum
Ian> values part of the incremental linking ABI.  We won't remember to change
Ian> the incremental link version every time we change an enum value.  On the
Ian> other hand, it's fairly unlikely that we will ever change an enum
Ian> value.  Any suggestion on how to make this more foolproof?

Add a test case that checks all the values against hard-coded numbers.
If any check fails, have it print a message about the need to bump the
version.

Tom
More information about the Binutils mailing list