H.J. Lu hongjiu.lu@intel.com
Wed Aug 18 20:29:00 GMT 2010

• Previous message (by thread): [gold patch obvious] Remove unnecessary code in Sort_commons::operator()
• Next message (by thread): [gold patch committed] Fix 32-bit build
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi,

I checked in this patch to avoid bitfield.


H.J.
---
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 2777273..e18d5ac 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2010-08-18  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* config/tc-i386.c (build_modrm_byte): Check i.imm_operands
+	instead of VEXXDS.
+
 2010-08-18  Alan Modra  <amodra@gmail.com>
 
 	* macro.c (sub_actual): Add back ampersand suffix when no
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 0e36a3e..74e8b37 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -5264,15 +5264,15 @@ build_modrm_byte (void)
 			  && i.imm_operands == 1
 			  && (i.types[0].bitfield.imm8
 			      || i.types[i.operands - 1].bitfield.imm8)));
-	  if (i.tm.opcode_modifier.vexvvvv == VEXXDS)
+	  if (i.imm_operands == 2)
+	    source = 2;
+	  else
 	    {
 	      if (i.types[0].bitfield.imm8)
 		source = 1;
 	      else
 		source = 0;
 	    }
-	  else
-	    source = 2;
 	  break;
 	case 5:
 	  break;

---

• Previous message (by thread): [gold patch obvious] Remove unnecessary code in Sort_commons::operator()
• Next message (by thread): [gold patch committed] Fix 32-bit build
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list