Maciej W. Rozycki macro@codesourcery.com
Tue Jul 27 21:28:00 GMT 2010

• Previous message (by thread): [PATCH] MIPS/BFD: Handle MIPS16 GOT16 and GPREL16 relocs correctly
• Next message (by thread): [PATCH] MIPS: microMIPS ASE support
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Tue, 27 Jul 2010, Richard Sandiford wrote:

> > 	* elfxx-mips.h: Include "elf/mips.h".
> > 	(gprel16_reloc_p): New inline function.
> > 	* elfxx-mips.c (_bfd_mips_elf_check_relocs)
> > 	[R_MIPS16_GOT16, R_MIPS_GOT16, R_MIPS_GOT_HI16, R_MIPS_GOT_LO16]: 
> > 	Use got16_reloc_p.
> > 	(_bfd_mips_elf_relocate_section)[bfd_reloc_overflow]: Use 
> > 	gprel16_reloc_p.
> > 	* elf32-mips.c (mips_info_to_howto_rel): Likewise.
> > 	* elfn32-mips.c (mips_info_to_howto_rel): Likewise.
> 
> OK, thanks.  No idea how I managed to miss the GOT16 one. ;-(

 That's a merge error of some kind probably.  Overall we're under-tested. 
:(  No surprise given the number of corner cases.  And MIPS16 support 
seems to suffer particularly badly -- we've got just a couple of test 
cases AFAICT.  And the GCC or GDB test suites do not cover binutils 
functionality too well -- regressions of this kind if they happen there, 
mostly trigger by accident.

  Maciej

---

• Previous message (by thread): [PATCH] MIPS/BFD: Handle MIPS16 GOT16 and GPREL16 relocs correctly
• Next message (by thread): [PATCH] MIPS: microMIPS ASE support
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list