Home Original page

[RFA] [ARM] Fix Neon Alignment Syntax acceptance

Matthew Gretton-Dann matthew.gretton-dann@arm.com
Fri Jun 25 14:15:00 GMT 2010 
All,

Please can someone review, and approve the attached patch?

Most Neon load/store instructions accept an optional alignment
parameter.  The current syntax accepted by gas requires a comma before
the alignment parameter.  However, this is not what was originally
intended, and this patch corrects that.  We still accept the current
syntax as well.

This means that the following are now both valid:
	VLD1.8 {d0}, [r1, :128]
	VLD1.8 {d0}, [r1 :128]

We disassemble to the second form.

Proposed ChangeLogs:

gas/ChangeLog:
2010-06-25  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>

	* config/tc-arm.c (parse_neon_alignment): New function.
	(parse_address_main): Fix Neon load/store alignment parsing.


gas/testsuite/ChangeLog:
2010-06-25  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>

	* gas/arm/neon-ldst-align-bad.l: Update for Neon alignment 
	syntax fix.
	* gas/arm/neon-ldst-align-bad.s: Likewise.
	* gas/arm/neon-ldst-es.d: Likewise.
	* gas/arm/neon-ldst-es.s: Likewise.

opcodes/ChangeLog:
2010-06-25  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>

	* arm-disc.c (parse_insn_neon):  Fix Neon alignment syntax.

Thanks,

Matt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1006-neon-alignment-syntax.patch
Type: text/x-patch
Size: 13063 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100625/fab7b495/attachment.bin>
More information about the Binutils mailing list