Home Original page

[PATCH][PR ld/10144] MIPS/BFD: Don't make debug section relocs dynamic

Maciej W. Rozycki macro@codesourcery.com
Thu Nov 4 17:48:00 GMT 2010 
On Thu, 4 Nov 2010, Richard Sandiford wrote:

> >  My understanding is the base framework just runs */*.exp from within 
> > ld/testsuite/ and it is the responsibility of the scripts themselves to 
> > filter the targets of concern.
> 
> Right.  My point was that [istarget mips*-*-linux*] => [is_elf_format];
> we don't support any non-ELF form of GNU/Linux on MIPS.  So I wouldn't
> expect to have to check is_elf_format if we're checking the second
> condition as well.  I'd still like to see that condition removed.

 Good point.  This can be added if a need arises from any other targets 
added.

> Oh, yeah, much as it pains me to say it: s/favourite/favorite/.

 Indeed -- I recall seeing a language convention reference posted to the 
list yesterday.  As a non-British it may be less of a pain to me, but 
still I try to stay consistent with the language I use (I wonder how the 
rule is going to play with the style of expression rather than just 
spelling, especially when American spelling is mixed with British style).  
Oh well...  There may be more of such subtleties in some of my outstanding 
patches -- I'll try to catch them as I go.

> Anyway, the new comment looks good, thanks.  Please install the
> elfxx-mips.c change now.  We can apply the testsuite patch once
> the dc.a thing is sorted out.

 I am assuming you're trying to minimise the risk of a cross-target 
avalanche of failures from the generic test case with the imminent release 
in mind; certainly the lone MIPS/n32 misbehaviour (which doesn't trigger a 
failure here) cannot justify such an extreme caution.

 Thanks for your review; I'm proceeding with the elfxx-mips.c change 
straight away.

  Maciej
More information about the Binutils mailing list