Home Original page

[PATCH, take 2] Fix ld-plugin testsuite noise properly [was Re: [PATCH] Fix oopsie in ld-plugin tests.]

Dave Korn dave.korn.cygwin@gmail.com
Fri Oct 15 19:24:00 GMT 2010 
On 15/10/2010 20:02, Hans-Peter Nilsson wrote:
>> Date: Fri, 15 Oct 2010 20:18:21 +0100
>> From: Dave Korn <dave.korn.cygwin@gmail.com>
> 
>> On 15/10/2010 19:10, Hans-Peter Nilsson wrote:
>>>> Date: Thu, 14 Oct 2010 06:24:04 +0100
>>>> From: Dave Korn <dave.korn.cygwin@gmail.com>
>>>> ld/testsuite/ChangeLog:
>>>>
>>>> 	* ld-plugin/plugin.exp: Don't error out if there is no target compiler
>>>> 	available, make tests UNSUPPORTED instead.
>>>> +if { !$can_compile || $failed_compile } {
>>>>      foreach testitem $plugin_tests {
>>>>  	unresolved [lindex $testitem 0]
>>> Incorrect, or you sent and committed the wrong patch.  You made
>>> them UNRESOLVED, which causes make to (still) return an error.
>>   Sorry, that was what you suggested in your off-list email.  Did you mean to
>> says UNSUPPORTED perhaps?
> 
> Yes, as I also mentioned off-list, presumably after you sent this. :)

  Heh, just a bit!

> (and the patch didn't match the ChangeLog; UNSUPPORTED != UNRESOLVED)
> Right, too many choices!

  The attached patch makes it UNSUPPORTED if no compiler is found, and only
UNRESOLVED if there's a compiler error of some sort.

ld/testsuite/ChangeLog:

	* ld-plugin/plugin.exp: Mark tests UNSUPPORTED, not UNRESOLVED, if
	no suitable target compiler is available.

  OK for trunk?

    cheers,
      DaveK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ld-plugin-fixes-4-tests-refix.diff
Type: text/x-c
Size: 1610 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20101015/165e3731/attachment.bin>
More information about the Binutils mailing list