Ralf Wildenhues Ralf.Wildenhues@gmx.de
Tue Oct 26 20:22:00 GMT 2010

• Previous message (by thread): [PATCH] fix testsuite ldscripts problem [was Re: mips and frv testsuite failures after plugin patch]
• Next message (by thread): [PATCH] fix testsuite ldscripts problem [was Re: mips and frv testsuite failures after plugin patch]
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Dave,

* Dave Korn wrote on Mon, Oct 25, 2010 at 10:23:18PM CEST:
> --- ld/Makefile.am	14 Oct 2010 01:31:29 -0000	1.292
> +++ ld/Makefile.am	25 Oct 2010 19:45:45 -0000
> @@ -1916,7 +1916,16 @@ EXTRA_ld_new_SOURCES += $(ALL_EMULATION_
>  # This is the real libbfd.a created by libtool.
>  TESTBFDLIB = @TESTBFDLIB@
>  
> -check-DEJAGNU: site.exp
> +ldscripts-link:
> +	-eval "x`$(LIBTOOL) --config | $(GREP) ^objdir=`" && \
> +	if test -d $$xobjdir; then \
> +	    test ! -e $$xobjdir/ldscripts \
> +		&& $(LN_S) ../ldscripts $$xobjdir/ldscripts; \

This won't work when LN_S is 'cp -p'; instead, please do
  cd $$xobjdir && $(LN_S) ../ldscripts ldscripts

as documented in 'info Autoconf --index LN_S'.

Besides, Solaris /bin/sh test does not have -e, so you might want to
prefer -f or -r if you're still going to use the test.

> +	fi
> +
> +.PHONY: ldscripts-link
> +
> +check-DEJAGNU: site.exp ldscripts-link
>  	srcroot=`cd $(srcdir) && pwd`; export srcroot; \
>  	r=`pwd`; export r; \
>  	LC_COLLATE=; LC_ALL=; LANG=; export LC_COLLATE LC_ALL LANG; \

Cheers,
Ralf

---

• Previous message (by thread): [PATCH] fix testsuite ldscripts problem [was Re: mips and frv testsuite failures after plugin patch]
• Next message (by thread): [PATCH] fix testsuite ldscripts problem [was Re: mips and frv testsuite failures after plugin patch]
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list