Home Original page

[PATHC, GOLD]: Allow evaluation without a result section

Nick Clifton nickc@redhat.com
Thu Sep 30 06:42:00 GMT 2010 
Hi Ian,

  This is a small tidy up patch for GOLD.  It allows the eval_with_dot()
  and eval_maybe_dot() methods to be called without the result_section
  and result_alignment parameters, if the caller is not interested in
  them.
  
  It allows several dummy local variables to be removed from the source
  code, but it does mean that the eval functions now include a small
  amount of extra processing when they check to see whether the
  result_section pointer is NULL.  (The code to check for a NULL
  result_alignment pointer was already present).

  Tested without any regressions on an i686-linux-gnu target.

  Is the patch OK to apply or is this not the right way to go about
  tidying up this bit of the code ?

Cheers
  Nick

gold/ChangeLog
2010-09-30  Nick Clifton  <nickc@redhat.com>

	* expression.c (eval): Remove dummy argument.
        (eval_maybe_dot): Check for result_section_pointer being NULL.
        (value): Likewise.
        (BINARY_EXPRESSION): Likewise.
        (arg_value): Provide a default value for the arg_section_pointer
        parameter.
        * script-sections.cc (finalize_symbols): Remove dummy argument.
        (set_section_addresses): Likewise.
        (do_write_to_buffer): Likewise.
        (finalize_symbols): Likewise.
        * script.h (eval_with_dot): Provide default values for
        result_section and result_alignment parameters.
        (eval_maybe_dot): Likewise.
        
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gold.patch
Type: text/x-patch
Size: 18836 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100930/ef95294f/attachment.bin>
More information about the Binutils mailing list