Home Original page

[PATCH] ARM: gas not detecting invalid operands for Thumb2 ADD{S} and SUB{S}

Paul Carroll pcarroll@codesourcery.com
Fri Mar 11 18:01:00 GMT 2011 
On 3/11/2011 6:26 AM, Paul Brook wrote:
> The patch looks ok, though I think the testcases could use some
> reorganisation.  I'd prefer two assembly files, one with insns valid in both
> ARM and Thumb mode, the other which is only valid in ARM mode.  Assemble both
> in both modes.  There should already be existing tests
> (e.g. sp-pc-usage-t) that cover the former.

Maybe the best thing to do is just remove the 2 positive test cases and 
keep only the 1 negative test case.
I'll just assume the test suite does enough validation with existing tests.

>> +@ test case of ADD{S} and SUB{S} instructions in ARM mode
> Too vague.  You're testing use of SP in these insns.

For the negative test case, I can adjust the comment to this:
     # Test of invalid operands for ADD{S} and SUB{S} instructions
     # in Thumb2 mode.  The instruction form being testing
     # involves having the first 2 operands be SP.

>> +	.file	"s6163c.c"
> Looks bogus.

That can easily be removed from the negative test case.
More information about the Binutils mailing list