[RFA] Supplemtal patch for use only dwarf

[RFA] Supplemtal patch for use only dwarf_vma types in dwarf code

Pierre Muller pierre.muller@ics-cnrs.unistra.fr
Fri Mar 25 21:44:00 GMT 2011

Previous message (by thread): [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code
Next message (by thread): [patch/commited] vms: make code section read-only
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> -----Message d'origine-----
> De : binutils-owner@sourceware.org [mailto:binutils-owner@sourceware.org]
De
> la part de Nick Clifton
> Envoyé : vendredi 25 mars 2011 19:05
> À : Pierre Muller
> Cc : 'Kai Tietz'; 'H.J. Lu'; 'Binutils'
> Objet : Re: [RFA] Supplemtal patch for use only dwarf_vma types in dwarf
> code
> 
> Hi Pierre,
> 
> >    I have no real idea if those three cases are
> > really variables that can reach up to values that
> > do not fit in 4-bytes but it can not really hurt, can it?
> 
> Agreed.
> 
> > ChangeLog entry:
> > 2011-03-25  Pierre Muller<muller@ics.u-strasbg.fr>
> >
> > 	* dwarf.c (decode_location_expression): Use dwarf_vmatoa
> > 	function to display DW_OP_addr OP.
> > 	(process_debug_info): Use dwarf_vma type for local variables
> > 	length and type_offset.
> 
> Approved and applied - note: there were a couple of places where the
> "length" variable was being displayed in a printf() style output, so I
> updated these to use the dwarf_vmatoa() function as well.
Thanks for the approval.

  Just a small nit:
I noticed that the indentation of the patch seems strange
(modified lines are 1 column less indented)
I think it is related to tab/spaces issues...

Pierre

Previous message (by thread): [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code
Next message (by thread): [patch/commited] vms: make code section read-only
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the Binutils mailing list