Home Original page

[PATCH] gas: blackfin: gas: blackfin: reject invalid BYTEOP16P insns

Mike Frysinger vapier@gentoo.org
Tue Mar 29 05:41:00 GMT 2011 
The destination registers must be different with BYTEOP16P insns,
otherwise the hardware throws up an exception.  So reject them.

Committed.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

gas/:
2011-03-29  Mike Frysinger  <vapier@gentoo.org>

	* config/bfin-parse.y (BYTEOP16P): Return yyerror when dest
	reg $2 is the same as dest reg $4.

gas/testsuite/:
2011-03-29  Mike Frysinger  <vapier@gentoo.org>

	* gas/bfin/expected_errors.s: Add invalid BYTEOP16P insn tests.
	* gas/bfin/expected_errors.l: Add new error messages.
---
 gas/config/bfin-parse.y                  |    2 ++
 gas/testsuite/gas/bfin/expected_errors.l |    2 ++
 gas/testsuite/gas/bfin/expected_errors.s |    3 +++
 3 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/gas/config/bfin-parse.y b/gas/config/bfin-parse.y
index fa81a61..12e7525 100644
--- a/gas/config/bfin-parse.y
+++ b/gas/config/bfin-parse.y
@@ -831,6 +831,8 @@ asm_1:
 	{
 	  if (!IS_DREG ($2) || !IS_DREG ($4))
 	    return yyerror ("Dregs expected");
+	  else if (REG_SAME ($2, $4))
+	    return yyerror ("Illegal dest register combination");
 	  else if (!valid_dreg_pair (&$9, $11))
 	    return yyerror ("Bad dreg pair");
 	  else if (!valid_dreg_pair (&$13, $15))
diff --git a/gas/testsuite/gas/bfin/expected_errors.l b/gas/testsuite/gas/bfin/expected_errors.l
index 2f746db..216c8e1 100644
--- a/gas/testsuite/gas/bfin/expected_errors.l
+++ b/gas/testsuite/gas/bfin/expected_errors.l
@@ -101,3 +101,5 @@
 .*:127: Error: Differing source registers.
 .*:129: Error: Register mismatch.
 .*:131: Error: Illegal dest register combination. Input text was A0.H.
+.*:133: Error: Illegal dest register combination.
+.*:134: Error: Illegal dest register combination.
diff --git a/gas/testsuite/gas/bfin/expected_errors.s b/gas/testsuite/gas/bfin/expected_errors.s
index f6e3f6f..677103c 100644
--- a/gas/testsuite/gas/bfin/expected_errors.s
+++ b/gas/testsuite/gas/bfin/expected_errors.s
@@ -129,3 +129,6 @@
 	R0 = R3 + R4, R1 = R5 - R6;
 
 	R7 = A1.L + A1.H, R7 = A0.L + A0.H;
+
+	(R0, R0) = BYTEOP16P (R1:0, R3:2);
+	(R7, R7) = BYTEOP16P (R1:0, R3:2);
-- 
1.7.4.1
More information about the Binutils mailing list