Richard Sandiford rdsandiford@googlemail.com
Thu Nov 24 21:15:00 GMT 2011

• Previous message (by thread): [PATCH][PR ld/10144] MIPS/BFD: Don't make debug section relocs dynamic
• Next message (by thread): [PATCH] MIPS/gas/testsuite: Additional MIPS16 reloc conversion tests
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> @@ -6397,10 +6398,15 @@ macro (struct mips_cl_insn *ip)
>  	case 2:
>  	  macro_build (NULL, "packrl.ph", "d,s,t", treg, treg, sreg);
>  	  break;
> -	default:
> +	case 1:
> +	case 3:
>  	  macro_build (NULL, "balign", "t,s,2", treg, sreg,
>  		       (int) imm_expr.X_add_number);
>  	  break;
> +	default:
> +	  as_bad (_("BALIGN immediate not 0,1,2,3 (%lu)"),
> +		  (unsigned long) imm_expr.X_add_number);

"0, 1, 2 or 3" reads better to me and ties in well with:

		  as_bad (_("BALIGN immediate not 1 or 3 (%lu)")

> @@ -10728,8 +10744,7 @@ mips_ip (char *str, struct mips_cl_insn 
>  		return;
>  	      break;
>  
> -	    case '2': /* DSP 2-bit unsigned immediate in bit 11.  */
> -	      gas_assert (!mips_opts.micromips);
> +	    case '2': /* DSP 2-bit unsigned immediate in bit 11 or 14.  */

"bit 11 (for normal MIPS) or bit 14 (for microMIPS)".  Same for the others.

OK with those changes, thanks.

Richard

---

• Previous message (by thread): [PATCH][PR ld/10144] MIPS/BFD: Don't make debug section relocs dynamic
• Next message (by thread): [PATCH] MIPS/gas/testsuite: Additional MIPS16 reloc conversion tests
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list