Home Original page

[AArch64] Binutils/gas/ld port for ARM's new 64-bit architecture, AArch64 [6/6] binutils changes v2

Yufeng Zhang Yufeng.Zhang@arm.com
Tue Aug 7 17:30:00 GMT 2012 
Hi,

On 07/30/12 16:16, Joseph S. Myers wrote:
> On Mon, 30 Jul 2012, Yufeng Zhang wrote:
>
>> This patch adds the binutils changes of the AArch64 target support.
>
> Are you sure this is adding full support to readelf?  You appear to have
> some architecture-specific PT_*, SHT_* and SHF_* values in elf/aarch64.h,
> so readelf should know how to display those - and in general such support
> is conditioned on the architecture, so even if the names and values are
> the same as for ARM, I'd expect you to need conditionals to enable the
> decoding for AArch64 as well as for ARM.  (In general I'd advise going
> through the ELF ABI and making sure that all such architecture-specific
> values from the ABI are (a) present in elf/aarch64.h and (b) properly
> displayed by readelf.)

Thank you for your reviewing.

Please find the attached updated patch which has an improved 
implementation of the AArch64-port readelf.


Thanks,
Yufeng


Updated change log:

binutils/ChangeLog
2012-08-07  Ian Bolton  <ian.bolton@arm.com>
             Laurent Desnogues  <laurent.desnogues@arm.com>
             Jim MacArthur  <jim.macarthur@arm.com>
             Marcus Shawcroft  <marcus.shawcroft@arm.com>
             Nigel Stephens  <nigel.stephens@arm.com>
             Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
             Richard Earnshaw  <rearnsha@arm.com>
             Sofiane Naci  <sofiane.naci@arm.com>
             Tejas Belagod  <tejas.belagod@arm.com>
             Yufeng Zhang  <yufeng.zhang@arm.com>

         * readelf.c (guess_is_rela): Handle EM_AARCH64.
         (get_machine_name): Likewise.
         (get_aarch64_segment_type): New function.
         (get_segment_type): Handle EM_AARCH64 by calling the new function.
         (get_aarch64_section_type_name): New function.
         (get_section_type_name): Handle EM_AARCH64 by calling the new 
function.
         (is_32bit_abs_reloc): Handle EM_AARCH64.
         (is_32bit_pcrel_reloc): Likewise.
         (is_64bit_abs_reloc): Likewise.
         (is_64bit_pcrel_reloc): Likewise.
         (is_none_reloc): Likewise.

binutils/testsuite/ChangeLog
2012-08-07  Ian Bolton  <ian.bolton@arm.com>
             Laurent Desnogues  <laurent.desnogues@arm.com>
             Jim MacArthur  <jim.macarthur@arm.com>
             Marcus Shawcroft  <marcus.shawcroft@arm.com>
             Nigel Stephens  <nigel.stephens@arm.com>
             Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
             Richard Earnshaw  <rearnsha@arm.com>
             Sofiane Naci  <sofiane.naci@arm.com>
             Tejas Belagod  <tejas.belagod@arm.com>
             Yufeng Zhang  <yufeng.zhang@arm.com>

         * objdump.exp: Add AArch64.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: aarch64-binutils.v2.patch
Type: text/x-patch
Size: 4745 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20120807/f589fed7/attachment.bin>
More information about the Binutils mailing list