John Szakmeister john@szakmeister.net
Fri Jun 15 10:15:00 GMT 2012

• Previous message (by thread): [patch][gdb, testsuite] Fix .global directives in gdb.arch/arm-disp-step.S
• Next message (by thread): [PATCH] elf32-arm: error when encountering R_ARM_TLS_LE32 in a shared object
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

This appears to be a copy and paste error.  In this case though, FALSE
translates into bfd_reloc_ok, which is clearly the wrong status code.
Switched to bfd_reloc_notsupported to ensure that the linker exits with
an error code instead of producing a broken binary.
---
 bfd/elf32-arm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index e9157b2..826dd7e 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -9664,7 +9664,7 @@ elf32_arm_final_link_relocate (reloc_howto_type *           howto,
 	    (_("%B(%A+0x%lx): R_ARM_TLS_LE32 relocation not permitted in shared object"),
 	     input_bfd, input_section,
 	     (long) rel->r_offset, howto->name);
-	  return (bfd_reloc_status_type) FALSE;
+	  return bfd_reloc_notsupported;
 	}
       else
 	value = tpoff (info, value);
-- 
1.7.10.2

---

• Previous message (by thread): [patch][gdb, testsuite] Fix .global directives in gdb.arch/arm-disp-step.S
• Next message (by thread): [PATCH] elf32-arm: error when encountering R_ARM_TLS_LE32 in a shared object
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list