Home Original page

[PATCH/AARCH64] Fix elfNN_aarch64_howto_from_bfd_reloc for BFD_RELOC_AARCH64_NONE and ILP32

Marcus Shawcroft marcus.shawcroft@arm.com
Wed Jul 24 15:14:00 GMT 2013 
On 23/07/13 22:45, Andrew Pinski wrote:
> Hi,
>    The problem here is that the type inside elfNN_aarch64_howto_table
> for BFD_RELOC_AARCH64_NONE is 0 since that is the relocation number of
> NONE so we return NULL from elfNN_aarch64_howto_from_bfd_reloc but
> when really wanted to return a real howto.  This happens with TLS
> relaxation code when it is recording a relocation as being none.
>
> This fixes the problem by explicitly checking for
> BFD_RELOC_AARCH64_NONE and returning elfNN_aarch64_howto_none.
>
> OK?  Built and tested on aarch64-elf and aarch64-linux-gnu (with a few
> extra patches which adds ilp32 support).
>
> Thanks,
> Andrew
>
> ChangeLog:
> * elfnn-aarch64.c (elfNN_aarch64_howto_from_bfd_reloc): Handle
> BFD_RELOC_AARCH64_NONE explicitly.
>

Looks OK to me.

Thanks Andrew.

/Marcus
More information about the Binutils mailing list