Cary Coutant ccoutant@google.com
Tue Jul 30 21:42:00 GMT 2013

• Previous message (by thread): Mips target in gold - part 3
• Next message (by thread): Mips target in gold - part 3
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

> 3. nonvis.patch
> This patch adds a method in the class Symbol that sets the non-visibility part of the st_other field. Mips uses st_other's non-visibility part to record different flags about the symbol (whether it has plt stub, whether it is mips16 etc.)

Needs a ChangeLog entry.

--- a/gold/symtab.h
+++ b/gold/symtab.h
@@ -259,6 +259,11 @@ class Symbol
   nonvis() const
   { return this->nonvis_; }

+  // Set the non-visibility part of the st_other field.
+  void
+  set_nonvis(unsigned int nonvis)
+  { this->nonvis_ = nonvis; }

I believe that this should be a protected member -- you only use it
from a class derived from Symbol, right? I don't think there's any
reason to expose this interface publicly.

-cary

---

• Previous message (by thread): Mips target in gold - part 3
• Next message (by thread): Mips target in gold - part 3
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list