Home Original page

[GOLD] --as-needed change wrt undefined weak symbols

Ian Lance Taylor iant@google.com
Tue Mar 19 21:37:00 GMT 2013 
On Mon, Mar 18, 2013 at 7:34 PM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Mar 18, 2013 at 08:15:55AM -0700, Ian Lance Taylor wrote:
>>  We can build a
>> temporary vector of symbols with version != NULL for which that
>> condition is not true, and then walk that vector in the second loop.
>> There won't be many entries in it.
>
> Well, OK, but I wonder whether it is really worth doing?  Sometimes
> having two small loops is much better than having one large one.

Yes, but there are executables here with tens of thousands of dynamic
symbols, none of which are weak.

>         * symtab.h (Symbol::override_version): Make public.
>         * symtab.cc (Symbol_table::set_dynsym_indexes): Don't set object
>         is_needed by weak references.  Clear version for symbols defined
>         in as-needed objects that are not needed.

This is OK.

Thanks.

Ian
More information about the Binutils mailing list