Richard Sandiford rdsandiford@googlemail.com
Sat Nov 9 11:22:00 GMT 2013

• Previous message (by thread): [PATCH] MIPS opcode table loads
• Next message (by thread): [COMMITTED PATCH] *-*-nacl* layout: Drop requirement that some section have SEC_HAS_CONTENTS set.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

"Moore, Catherine" <Catherine_Moore@mentor.com> writes:
>> The patch adds the new flag to coprocessor as well as GPR loads, so the
>> name seems a bit misleading.  I think we should either
>> 
>> (a) restrict it to GPR loads and continue to use
>> INSN_COPRO_MEMORY_DELAY
>>     for coprocessors or
>> 
>> (b) rename it to INSN_LOAD_MEMORY and include it in CLD:
>> 
>>       #define CLD	(INSN_LOAD_MEMORY|INSN_COPROC_MEMORY_DELAY)
>> 
>> I've a slight preference for (2) because of the symmetry with
>> INSN_STORE_MEMORY.  The flag would then be LM, for consistency with
>> SM.
>> 
>> At some point we should also add it to the MIPS16 and microMIPS tables, but
>> that can wait.
>> 
> I have a patch for the microMIPS opcode table that I'll post separately.
> I've rewritten the patch to conform to suggestion #2.  It's attached.
> Okay to commit?

Following on from Maciej's microMIPS comment, we'd better include LM
in ACLR and ASET here too.

OK with that change, thanks.

Richard

---

• Previous message (by thread): [PATCH] MIPS opcode table loads
• Next message (by thread): [COMMITTED PATCH] *-*-nacl* layout: Drop requirement that some section have SEC_HAS_CONTENTS set.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list