Home Original page

[PATCH] gold testsuite: use -Werror in -mtls-dialect=gnu2 check

Roland McGrath mcgrathr@google.com
Fri Oct 11 20:47:00 GMT 2013 
Without this, the configure check thinks Clang groks -mtls-dialect=gnu2
(because its failure to grok it is only a warning in the configure check)
but then the actual attempts to use it barf (because by then -Werror has
been enabled).

OK for trunk and 2.24?


Thanks,
Roland


gold/
	* configure.ac (TLS_GNU2_DIALECT): Use -Werror in test.
	* configure: Regenerate.

--- a/gold/configure
+++ b/gold/configure
@@ -6472,7 +6472,7 @@ fi


 save_CFLAGS="$CFLAGS"
-CFLAGS="$CFLAGS -fpic -mtls-dialect=gnu2"
+CFLAGS="$CFLAGS -Werror -fpic -mtls-dialect=gnu2"
 cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */

--- a/gold/configure.ac
+++ b/gold/configure.ac
@@ -389,8 +389,13 @@ fi
 AM_CONDITIONAL(OMP_SUPPORT, test "$gold_cv_c_threadprivate" = "yes")

 dnl Test for the -ftls-dialect=gnu2 option.
+dnl Use -Werror in case of compilers that make unknown -m options warnings.
+dnl They would pass the test here, but fail in actual use when $WARN_CFLAGS
+dnl gets set later by default Autoconf magic to include -Werror.  (We are
+dnl assuming here that there is no compiler that groks -mtls-dialect=gnu2
+dnl but does not grok -Werror.)
 save_CFLAGS="$CFLAGS"
-CFLAGS="$CFLAGS -fpic -mtls-dialect=gnu2"
+CFLAGS="$CFLAGS -Werror -fpic -mtls-dialect=gnu2"
 AC_COMPILE_IFELSE([
 __thread int i;
 void foo (void)
More information about the Binutils mailing list