Home Original page

git is live

Alan Modra amodra@gmail.com
Wed Oct 30 00:37:00 GMT 2013 
On Wed, Oct 30, 2013 at 08:53:32AM +1030, Alan Modra wrote:
> I tried to push some testsuite changes today, and got
> 
> remote: ld/testsuite/ld-powerpc/tlsexe.r:50: trailing whitespace.
> remote: + +03 +\.tdata \.dynamic \.opd \.got \.plt 
> remote: ld/testsuite/ld-powerpc/tlsexe.r:90: trailing whitespace.
> remote: +.* SECTION +LOCAL +DEFAULT +13 
> ...
> remote: error: hook declined to update refs/heads/master
> 
> I agree that it's good to reject trailing whitespace generally, but
> the testsuite is a little special.  We're matching tool output.  If,
> as in this example, readelf emits trailing whitespace then we
> shouldn't need to write a regex to match it.  Can this be fixed
> easily?

Come to think of it, maybe no trailing whitespace in the testsuite
isn't such a bad thing.  If the testsuite matched all trailing spaces
with " *" then the bar to updating readelf and objdump -d to not emit
trailing spaces is that much lower.

-- 
Alan Modra
Australia Development Lab, IBM
More information about the Binutils mailing list