Home Original page

[PATCH] Fix: binutils testsuite builds status wrapper unconditionally

Anton Kolesov Anton.Kolesov@synopsys.com
Mon Sep 16 11:19:00 GMT 2013 
Hi Alan,

Are you sure it is redundant? That would change current default behavior of using testglue. Without this test condition becomes false, if no value is set explicitly. 

--
Anton Kolesov


> -----Original Message-----
> From: binutils-owner@sourceware.org [mailto:binutils-owner@sourceware.org]
> On Behalf Of Alan Modra
> Sent: 14 September 2013 06:57
> To: Anton Kolesov
> Cc: binutils@sourceware.org; Jeremy Bennett (Jeremy.bennett@embecosm.com);
> Simon Cook (simon.cook@embecosm.com)
> Subject: Re: [PATCH] Fix: binutils testsuite builds status wrapper
> unconditionally
> 
> On Fri, Sep 13, 2013 at 12:19:26PM +0000, Anton Kolesov wrote:
> > --- binutils-ref/binutils/testsuite/binutils-all/objcopy.exp	2012-03-
> 13 04:41:22.000000000 +0400
> > +++ binutils-2.23.52/binutils/testsuite/binutils-all/objcopy.exp
> 	2013-09-13 15:41:07.650678480 +0400
> > @@ -561,7 +561,14 @@
> >      global test_prog
> >      global host_triplet
> >
> > -    set res [build_wrapper testglue.o]
> > +    if { [target_info exists needs_status_wrapper] == 0 || \
> > +         ([target_info needs_status_wrapper] != "" && \
> > +          [target_info needs_status_wrapper] != "0") } {
> > +        set res [build_wrapper testglue.o]
> > +    } else {
> > +        set res ""
> > +    }
> > +
> >      set flags { debug }
> >
> >      if { [istarget *-*-uclinux*] && ![istarget tic6x-*-*] } {
> 
> This is OK without the redundant "target_info exists" test.
> 
> --
> Alan Modra
> Australia Development Lab, IBM
More information about the Binutils mailing list