Home Original page

[PATCH] aarch64: move bogus assertion

Marcus Shawcroft marcus.shawcroft@gmail.com
Mon Oct 20 12:05:00 GMT 2014 
On 20 October 2014 10:22, Jan Beulich <JBeulich@suse.com> wrote:
> Asserting "idx" to be non-negative when subsequent code handles this
> case is bogus. In fact the assertion triggers e.g. when mistakenly
> using the arm32 comment character @ following an instruction.
>
> While doing this I also noticed that despite there being local
> variables "detail" and "idx", not all places where they could be used
> did actually make use of them, so this is being adjusted at once.
>
> Finally, for the code to be slightly more robust, also change
> comparisons against -1 to such checking for a (non-)negative value.
>
> gas/
> 2014-10-20  Jan Beulich <jbeulich@suse.com>

Double space before <.

>
>         * config/tc-aarch64.c (output_operand_error_record): Move down
>         assertion of idx being non-negative. Use local variables when
>         available.

OK, thanks.


Tristan, Are we OK to back port this to the 2.25 branch ?

Cheers
/Marcus
More information about the Binutils mailing list