Richard Sandiford rdsandiford@googlemail.com
Tue Oct 21 21:06:00 GMT 2014

• Previous message (by thread): [Patch, MIPS] Add Octeon3 support
• Next message (by thread): [Patch, MIPS] Add Octeon3 support
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Richard Sandiford <rdsandiford@googlemail.com> writes:
> "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@caviumnetworks.com> writes:
>> Hi,
>>
>> Updating octeon3 in doc/c-mips.texi.
>>
>> Please review the patch and let us know if there should be any
>> further modifications.
>>
>> Thanks,
>
> To echo Matthew's reply, sorry for the delay in getting to this.
>
>> +/* True if CPU is Octeon3 or higher */
>> +#define CPU_IS_OCTEON3(CPU) ((CPU) == CPU_OCTEON3)
>
> Please drop this bit, since it's never used.
>
> OK with that change and with Matthew's comment about .MIPS.abiflags
> addressed.

Sorry, I'm getting rusty.  Please also add a testcase for the new
instructions.  That's probably a significant enough change to need
another round of review.

Thanks,
Richard

---

• Previous message (by thread): [Patch, MIPS] Add Octeon3 support
• Next message (by thread): [Patch, MIPS] Add Octeon3 support
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list