Alan Modra amodra@gmail.com
Wed Oct 22 22:51:00 GMT 2014

• Previous message (by thread): [PATCH V2] ARM: plt_size functions need to read instructions in right byte order
• Next message (by thread): [PATCH V2] ARM: plt_size functions need to read instructions in right byte order
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Tue, Oct 21, 2014 at 10:25:13PM -0700, Victor Kamensky wrote:
> +  if ((elf_elfheader (abfd)->e_flags) & EF_ARM_BE8)
                                       ^ this parenthesis is in the
wrong place.  gcc will warn about "if (x & y)", breaking -Werror
builds.  Writing "if ((x & y))" silences the gcc warning, so you
should write

  if ((elf_elfheader (abfd)->e_flags & EF_ARM_BE8))

or as I suggested in the previous email (without explaining why)

  if ((elf_elfheader (abfd)->e_flags & EF_ARM_BE8) != 0)

The patch is OK to commit with that change.

-- 
Alan Modra
Australia Development Lab, IBM

---

• Previous message (by thread): [PATCH V2] ARM: plt_size functions need to read instructions in right byte order
• Next message (by thread): [PATCH V2] ARM: plt_size functions need to read instructions in right byte order
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list