Home Original page

[PING 2] RE: [PATCH, ARM] Add support for value 3 of Tag_ABI_VFP_args attribute

Thomas Preud'homme thomas.preudhomme@arm.com
Fri Oct 24 14:24:00 GMT 2014 
Hi all,

Has any reviewer a bit of spare time to take a look at this patch?

Best regards,

Thomas

> -----Original Message-----
> From: binutils-owner@sourceware.org [mailto:binutils-
> owner@sourceware.org] On Behalf Of Thomas Preud'homme
> Sent: Thursday, October 09, 2014 8:11 AM
> To: binutils@sourceware.org
> Subject: RE: [PATCH, ARM] Add support for value 3 of Tag_ABI_VFP_args
> attribute
> 
> Ping?
> 
> I reattached the patch to this email.
> 
> Please apologize if an answer usually takes more time, I'm not au fait of
> how binutils community works.
> 
> Best regards,
> 
> Thomas
> 
> > -----Original Message-----
> > From: binutils-owner@sourceware.org [mailto:binutils-
> > owner@sourceware.org] On Behalf Of Thomas Preud'homme
> > Sent: Sunday, September 28, 2014 4:56 PM
> > To: binutils@sourceware.org
> > Subject: [PATCH, ARM] Add support for value 3 of Tag_ABI_VFP_args
> > attribute
> >
> > Hi,
> >
> > This patch adds support for the value 3 of the Tag_ABI_VFP_args EABI
> > attribute, in particular with linking. A file with value 3 for this attribute
> can
> > be linked to other files with any value for this attribute, for instance
> with
> > value 0 (softfloat, default) or value 1 (hardfloat). The patchs also
> extends
> > readelf and gdb to handle this new value and add testcases in bfd.
> >
> > ChangeLog are as follows:
> >
> > *** bfd/ChangeLog ***
> >
> > 2014-07-23  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* elf32-arm.c (elf32_arm_merge_eabi_attributes): Handle new
> > 	Tag_ABI_VFP_args value.
> > 	(elf32_arm_post_process_headers): Set e_flags in ELF header as
> > soft
> > 	float instead of hard float when Tag_ABI_VFP_args is 2 or 3.
> >
> > *** binutils/ChangeLog ***
> >
> > 2014-07-23  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* readelf.c (arm_attr_tag_ABI_VFP_args): Add "compatible".
> >
> > *** gdb/ChangeLog ***
> >
> > 2014-07-23  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* arm-tdep.c (arm_gdbarch_init): Explicitely handle value 3 of
> > 	Tag_ABI_VFP_args.
> >
> > *** gold/ChangeLog ***
> >
> > 2014-07-23  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* arm.cc (Target_arm::do_adjust_elf_header): Set e_flags in ELF
> > header
> > 	as soft float instead of hard float when Tag_ABI_VFP_args is 2 or
> > 3.
> > 	(Target_arm::merge_object_attributes): Handle new
> > Tag_ABI_VFP_args
> > 	value.
> >
> > *** ld/testsuite/ChangeLog ***
> >
> > 2014-07-23  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* ld-arm/attr-merge-2a.s: Add Tag_ABI_VFP_args.
> > 	* ld-arm/attr-merge-2b.s: Likewise.
> > 	* ld-arm/attr-merge-2.attr: Likewise.
> > 	* ld-arm/attr-merge-4a.s: Add Tag_ABI_FP_number_model and
> > 	Tag_ABI_VFP_args.
> > 	* ld-arm/attr-merge-4b.s: Likewise.
> > 	* ld-arm/attr-merge-4.attr: Likewise.
> > 	* ld-arm/attr-merge-6a.s: Likewise.
> > 	* ld-arm/attr-merge-6b.s: Likewise.
> > 	* ld-arm/attr-merge-6.attr: Add Tag_ABI_FP_number_model.
> >
> >
> > See patch in attachment.
> >
> > This was tested with with the binutils regression testsuite and no new
> > regressions were found. Is it OK for trunk?
> >
> > Best regards,
> >
> > Thomas Preud'homme
More information about the Binutils mailing list