[patch] Fix handling of common symbols with plugins

Cary Coutant ccoutant@google.com
Wed Sep 17 17:17:00 GMT 2014
> gold
> 2014-09-09  Rafael Ávila de Espíndola <respindola@mozilla.com>
>
>         * plugin.cc (Sized_pluginobj::do_add_symbols): Ignore isym->size.
>         * resolve.cc (Symbol_table::resolve): Don't override common symbols
>         during the replacement phase.

The gold patch looks good to me. Thanks!

> include
> 2014-09-09  Rafael Ávila de Espíndola <respindola@mozilla.com>
>
>         * plugin-api.h (ld_plugin_symbol): Note that size is ignored.

This is OK if the ld patch is also approved.

> ld
> 2014-09-09  Rafael Ávila de Espíndola <respindola@mozilla.com>
>
>         * plugin.c (asymbol_from_plugin_symbol): Ignore ldsym->size.
>         * testplug.c (parse_symdefstr): Ignore sym->size.

Maybe HJ should look at this?

-cary



More information about the Binutils mailing list