H.J. Lu hjl.tools@gmail.com
Thu Apr 21 11:18:00 GMT 2016

• Previous message (by thread): [RFC][PATCH] Check ELF relocs after opening all all input files
• Next message (by thread): [RFC][PATCH] Check ELF relocs after opening all all input files
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Thu, Apr 21, 2016 at 3:35 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi H.J.
>
> Ooo - I forgot to mention one other feature of the patch, which
> you might find objectionable.  It changes the loop in lang_check_relocs()
> so that it does not terminate when a reloc check fails.  Instead
> I thought it better to carry on processing the remaining bfds, in
> case there are further errors that can be reported to the user.
>
> Cheers
>   Nick

It is OK as long as there is no regression.   BTW, you
should remove

&& bfd_get_flavour (link_info.output_bfd) == bfd_target_elf_flavour)

before the loop.


-- 
H.J.

---

• Previous message (by thread): [RFC][PATCH] Check ELF relocs after opening all all input files
• Next message (by thread): [RFC][PATCH] Check ELF relocs after opening all all input files
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list