Home Original page

[committed, PATCH] Always create dynsym section with dynamic sections

H.J. Lu hjl.tools@gmail.com
Mon Apr 25 16:03:00 GMT 2016 
On Mon, Apr 25, 2016 at 6:41 AM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Apr 25, 2016 at 05:47:15AM -0700, H.J. Lu wrote:
>> On Sun, Apr 24, 2016 at 7:18 PM, Faraz Shahbazker
>> <faraz.shahbazker@imgtec.com> wrote:
>> > On 04/23/16 18:42, H.J. Lu wrote:
>> >> Here is a patch.  Does it work for you?
>> > Yes, this works.
>> >
>>
>> Any other comments, feedbacks for my patch?
>
> I think you'd better look at all places that test dynsymcount.  For
> instance, bfd_elf_size_dynsym_hash_dynstr.

I checked.  They look OK.

> This should really have been done when you committed
> https://sourceware.org/ml/binutils/2016-02/msg00326.html and that
> patch should have explained why the change was made.  "We should
> always create the dynsym section, even if it is empty, with dynamic
> sections" doesn't explain anything about why the change was made.  In
> fact, the explanation for the patch was no better than "We should do
> what this patch does".

The issue is some dynamic tags (sections) are mandatory in .dynamic
section even if they are empty.  MIPS backend use dynsymcount, which
is intended for the mandatory DT_SYMTAB (.dynsym section), to build
static executable, which doesn't have dynamic section.  Here is the
updated patch.  Is it OK for master?


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Always-count-the-NULL-entry-in-dynamic-symbol-table.patch
Type: text/x-patch
Size: 2217 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20160425/638eb0e6/attachment.bin>
More information about the Binutils mailing list