[PATCH] msp430: Set DWARF2_ADDR_SIZE to 4

Nick Clifton nickc@redhat.com
Mon Feb 1 10:24:00 GMT 2016
Hi Kevin,

> msp430: Set DWARF2_ADDR_SIZE to 4.
>
> This change makes gas's notion of the msp430 dwarf2 address size match
> that of gcc and gdb.

Hmm - will this change also affect the information in the .eh_frame section ?  If so then maybe this function: bfd/elf32-msp430.c:elf32_msp430_eh_frame_address_size will need to be updated as well.


> Without this change, addresses in .debug_line are encoded in two bytes
> for some multilibs.  When GDB reads the address for
> DW_LNE_set_address, it uses the pointer size provided by the CU.  When
> these values don't match, GDB reads the wrong number of bytes.

Would it be possible to add a GAS test for this ?  Or maybe a BINUTILS test instead ?

Did you regression test your patch ?  With both the default and the -mlarge multilibs ?  In fact since we are talking about debug information generation, please could you tell us what affect this patch has on the MSp430 GDB testsuite results ?

Cheers
   Nick



More information about the Binutils mailing list