Home Original page

[PATCH] [PowerPC VLE] Add LSP instructions support

Alexander Fedotov alfedotov@gmail.com
Mon Aug 21 10:13:00 GMT 2017 
Hello Alan

Please find attached new version.

BTW I found some mess with tabs and spaces in ppc-opc.c

Here I see tabs+spaces:

static long
extract_dm (unsigned long insn,
        ppc_cpu_t dialect ATTRIBUTE_UNUSED,
        int *invalid)

meanwhile here is only only spaces:

static unsigned long
insert_vlesi (unsigned long insn,
            long value,
            ppc_cpu_t dialect ATTRIBUTE_UNUSED,
            const char **errmsg ATTRIBUTE_UNUSED)


Which one is correct ?

Alex


On Mon, Aug 21, 2017 at 12:37 PM, Alan Modra <amodra@gmail.com> wrote:
> On Sun, Aug 20, 2017 at 12:15:11AM +0300, Alexander Fedotov wrote:
>> This patch adds LSP instructions support to PowerPC VLE. Based against
>> current master branch.
>
> This is OK with a few fixes.
>
>> +2017-08-19  Alexander Fedotov <alexander.fedotov@nxp.com>
>> +         Edmar Wienskoski <edmar.wienskoski@nxp.com
>> +
>> +     *gas/testsuite/gas/ppc/lsp-checks.d: New test
>> +     *gas/testsuite/gas/ppc/lsp-checks.l: New
>> +     *gas/testsuite/gas/ppc/lsp-checks.s: New
>> +     *gas/testsuite/gas/ppc/lsp.d: New
>> +     *gas/testsuite/gas/ppc/lsp.s: New
>> +     *gas/testsuite/gas/ppc/ppc.exp: Run new tests.
>> +
>
> Files in a ChangeLog should be relative to the ChangeLog, and there
> should be a space after the '*'.
>
>> +static unsigned long
>> +insert_evuimm2_ex0 (unsigned long insn,
>> +         long value,
>> +         ppc_cpu_t dialect ATTRIBUTE_UNUSED,
>> +         const char **errmsg)
>
> Formatting here and on other new functions is broken.  It should be
>
> static unsigned long
> insert_evuimm2_ex0 (unsigned long insn,
>                     long value,
>                     ppc_cpu_t dialect ATTRIBUTE_UNUSED,
>                     const char **errmsg)
>
> Maybe the tabs were eaten by your email client?  There are other minor
> whitespace issue too.  If you add the following to you binutils
> .git/config under the [core] heading, git will show them to you
>
>         whitespace = indent-with-non-tab,space-before-tab,trailing-space
>
> --
> Alan Modra
> Australia Development Lab, IBM



-- 
Best regards,
AF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PowerPC-VLE-Add-LSP-instructions-support_v2.patch
Type: text/x-patch
Size: 123289 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20170821/e912c66b/attachment.bin>
More information about the Binutils mailing list