Home Original page

[PATCH] [PowerPC VLE] Add LSP instructions support

Alexander Fedotov alfedotov@gmail.com
Mon Aug 21 13:49:00 GMT 2017 
>> If you can commit with that fixed, please go ahead.  If
>> not, no need to post another patch.  I'll commit it for you with the
>> ChangeLog fixed.

Yes please, I have no permission to push on binutils-gdb.git

Best regards,
Alex

On Mon, Aug 21, 2017 at 3:45 PM, Alexander Fedotov <alfedotov@gmail.com> wrote:
>> This is still incorrect.  Paths are supposed to be relative to the
>> directory containing the ChangeLog file, so you need to lose the
>> gas/ prefix.  If you can commit with that fixed, please go ahead.  If
>> not, no need to post another patch.  I'll commit it for you with the
>> ChangeLog fixed.
>
> Well I have no write permissions.
> Fixed :)
>
>
>
> On Mon, Aug 21, 2017 at 3:31 PM, Alan Modra <amodra@gmail.com> wrote:
>> On Mon, Aug 21, 2017 at 01:12:37PM +0300, Alexander Fedotov wrote:
>>> Hello Alan
>>>
>>> Please find attached new version.
>>>
>>> BTW I found some mess with tabs and spaces in ppc-opc.c
>>
>> Yes, I see.  Indentation is supposed to be tabs+spaces.  (You can
>> infer that from the GNU coding standard saying that it recommends the
>> default style of the "indent" program.  However, as far as I know the
>> coding standard doesn't call for tabs explicitly, so there is some
>> room for dissenting opinion.)
>>
>>> --- a/gas/ChangeLog
>>> +++ b/gas/ChangeLog
>>> @@ -1,3 +1,13 @@
>>> +2017-08-19  Alexander Fedotov <alexander.fedotov@nxp.com>
>>> +         Edmar Wienskoski <edmar.wienskoski@nxp.com
>>> +
>>> +     * gas/testsuite/gas/ppc/lsp-checks.d: New test
>>> +     * gas/testsuite/gas/ppc/lsp-checks.l: New
>>> +     * gas/testsuite/gas/ppc/lsp-checks.s: New
>>> +     * gas/testsuite/gas/ppc/lsp.d: New
>>> +     * gas/testsuite/gas/ppc/lsp.s: New
>>> +     * gas/testsuite/gas/ppc/ppc.exp: Run new tests.
>>
>> This is still incorrect.  Paths are supposed to be relative to the
>> directory containing the ChangeLog file, so you need to lose the
>> gas/ prefix.  If you can commit with that fixed, please go ahead.  If
>> not, no need to post another patch.  I'll commit it for you with the
>> ChangeLog fixed.
>>
>> --
>> Alan Modra
>> Australia Development Lab, IBM
>
>
>
> --
> Best regards,
> AF



-- 
Best regards,
AF
More information about the Binutils mailing list