Home Original page

[PATCH] MIPS: Fix GOT page counter in multi-got links

Cary Coutant ccoutant@gmail.com
Thu Apr 5 16:49:00 GMT 2018 
> Thanks, however there is a problem. When I originally submitted the
> patch I thought the FSF copyright assignment for *@mips.com had been
> sorted out but I have now learned that it was not (I think), so the
> commit may have to be reverted.

These patch (the original and the revised one) are small enough, in my
judgement, that we don't need the assignment.

> Also, off list, someone pointed out some improvements to the patch (only
> simplifications - the patch as committed still works). These ended up in
> v3 which was attached to the bug report just now. Someone poked me to
> submit the v3 which I was about to do until you committed the original
> patch :)

I've reverted the original and applied your revised patch, which for
the record, is attached.

-cary

gold/
2018-04-05  James Cowgill  <james.cowgill@mips.com>

        PR gold/22770
        * mips.cc (Mips_got_info::record_got_page_entry): Don't insert
        Got_page_entry for object's GOT.
        (Mips_got_info::add_got_page_entries): Add all pages from from's GOT.
        Rename to add_got_page_count.
        (Got_page_entry): Remove num_pages.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr22770-v3.patch
Type: application/octet-stream
Size: 5713 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20180405/e5251a9c/attachment.obj>
More information about the Binutils mailing list