ld testsuite use of notarget
Maciej W. Rozycki
macro@linux-mips.org
Wed Aug 1 12:56:00 GMT 2018
More information about the Binutils mailing list
Wed Aug 1 12:56:00 GMT 2018
- Previous message (by thread): [PATCH, RX] Add target rx-*-linux
- Next message (by thread): Propagate from gcc: Add linker_output as prefix for LTO temps
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, 11 Jul 2018, Alan Modra wrote: > > This is not a bug, we do not support the GNU hash for the MIPS target > > due to psABI restrictions on dynsym table ordering. So I'd rather left > > it with #notarget for an accurate UNSUPPORTED result. > > I think it is better as an xfail. xfail doesn't necessarily mean you > have a bug, just that the test is expected to fail. Suppose in some > future patch someone enabled GNU hash for mips targets. Then an XPASS > on this test indicates a bug! (My point 3 in why notarget is a bad > idea.) Fair enough. > > I think this test case is broken, I fail to see from PR ld/20022 why it > > insists on using `.text' for relocated data rather than `.data' (and then > > it would work for all targets). There's nothing specific to `.text' here > > AFAICT. > > True, except the test uses -e _start and it's unusual for an entry > point to be in .data. I'll see how that goes. FWIW I use `-e 0' when an entry point is required in a test case to keep LD quiet and the actual value does not matter for the scenario covered. Maciej
- Previous message (by thread): [PATCH, RX] Add target rx-*-linux
- Next message (by thread): Propagate from gcc: Add linker_output as prefix for LTO temps
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Binutils mailing list