Jan Beulich JBeulich@suse.com
Thu Aug 9 07:42:00 GMT 2018

• Previous message (by thread): [PATCH 1/2] gas/as.c: print input and output details when error
• Next message (by thread): [PATCH 1/2] gas/as.c: print input and output details when error
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

>>> On 09.08.18 at 05:49, <liezhi.yang@windriver.com> wrote:
> --- a/gas/as.c
> +++ b/gas/as.c
> @@ -1259,8 +1259,10 @@ main (int argc, char ** argv)
>  	      if (sib.st_ino == sob.st_ino && sib.st_ino != 0)
>  		{
>  		  /* Don't let as_fatal remove the output file!  */
> +		  saved_out_file_name = xstrdup (out_file_name);
>  		  out_file_name = NULL;
> -		  as_fatal (_("The input and output files must be distinct"));
> +		  as_fatal (_("The input (%s, ino: %ld) and output (%s, ino: %ld) files must be distinct"),
> +			   argv[i], sib.st_ino, saved_out_file_name, sob.st_ino);

The if() condition guarantees both ino-s to be the same - why
print the same number twice? Instead, in your next patch,
perhaps also print dev?

Jan

---

• Previous message (by thread): [PATCH 1/2] gas/as.c: print input and output details when error
• Next message (by thread): [PATCH 1/2] gas/as.c: print input and output details when error
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list