Nick Clifton nickc@redhat.com
Mon Feb 12 12:08:00 GMT 2018

• Previous message (by thread): [PATCH] gas: xtensa: fix trampoline placement
• Next message (by thread): [PATCH] gas: xtensa: fix trampoline placement
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Max,

  Would you mind updating your recent commits please ?

> +	    /* Don't choose trampoline that contains the source.  */
> +	    if (source >= trampoline_frag->fr_address &&
> +		source <= trampoline_frag->fr_address + trampoline_frag->fr_fix)
> +	      continue;

  The GNU Coding standard requires that boolean conditional 
  operators should be at the start of a line, not the end:

https://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting

  So the above fragment, for example, should be:

	    /* Don't choose trampoline that contains the source.  */
	    if (source >= trampoline_frag->fr_address
		&& source <= trampoline_frag->fr_address + trampoline_frag->fr_fix)
	      continue;

  Thanks.

Cheers
  Nick

---

• Previous message (by thread): [PATCH] gas: xtensa: fix trampoline placement
• Next message (by thread): [PATCH] gas: xtensa: fix trampoline placement
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list