Home Original page

Adjust test for PR ld/22269

Nick Clifton nickc@redhat.com
Mon Jan 29 14:08:00 GMT 2018 
Hi Eric,

> on the SPARC architecture, you need to pass a special flag to GAS when you're 
> assembling PIC/PIE code or else you get a wrong relocation for the GOT symbol.
> 
> Tested on SPARC64/Linux (where it fixes PR22269-1), OK for mainline?

Approved - please apply.

> NB: it's rather confusing that run_ld_link_tests needs this tweak, but neither 
> run_ld_link_exec_tests nor run_cc_link_tests does.

Is this because they use gcc to create the assembler command line ?

> Maybe run_ld_link_tests should be fixed instead?

No.  None of those three functions has any target specific code in them, and
I would like to keep it that way.  However there might be a case for adding a
definition of ASFLAGS_PIC to ld/testsuite/config/default.exp.  Would you like
to look into that ?


> 2018-01-29  Eric Botcazou  <ebotcazou@adacore.com>
> 
> ld/
> 	PR ld/22269
> 	* testsuite/ld-elf/shared.exp (AFLAGS_PIC): Define on SPARC.
> 	(pr22269-1): Pass AFLAGS_PIC to the assembler.

Cheers
  Nick
More information about the Binutils mailing list