Home Original page

Error for mismatched powerpc ABI tags

Carlos O'Donell carlos@redhat.com
Thu Jul 5 16:09:00 GMT 2018 
On 07/04/2018 08:50 PM, Alan Modra wrote:
> And report the two input files that are incompatible rather than
> reporting that an input file is incompatible with the output.  I think
> that's rather more useful.  Saying that a file is incompatible with
> the output leaves a user wondering why the output file is that way,
> and those users who eventually figure out it has something to do with
> input files before the one reported don't know which input file.
> 
> Nick, I'd like this on the branch too please.
> 
> bfd/
> 	* elf-bfd.h (_bfd_elf_ppc_merge_fp_attributes): Update prototype.
> 	* elf32-ppc.c (_bfd_elf_ppc_merge_fp_attributes): Return error
> 	on mismatch.  Remove "warning: " from messages.  Track last bfd
> 	used to set tags.
> 	(ppc_elf_merge_obj_attributes): Likewise.  Handle status from
> 	_bfd_elf_ppc_merge_fp_attributes.
> 	* elf64-ppc.c (ppc64_elf_merge_private_bfd_data): Handle status
> 	from _bfd_elf_ppc_merge_fp_attributes.
> ld/
> 	* testsuite/ld-powerpc/attr-gnu-4-12.d: Update expected output.
> 	* testsuite/ld-powerpc/attr-gnu-4-13.d: Likewise.
> 	* testsuite/ld-powerpc/attr-gnu-4-21.d: Likewise.
> 	* testsuite/ld-powerpc/attr-gnu-4-23.d: Likewise.
> 	* testsuite/ld-powerpc/attr-gnu-4-31.d: Likewise.
> 	* testsuite/ld-powerpc/attr-gnu-4-32.d: Likewise.
> 	* testsuite/ld-powerpc/attr-gnu-8-23.d: Likewise.
> 	* testsuite/ld-powerpc/attr-gnu-12-21.d: Likewise.
This looks awesome. Thanks for the changes Alan :-)

Error messages all remove 'warning:', and messages look good.

Fall through statement issues bfd_set_error if !ret, which 
turns this into errors and that looks good.

Anything we can do in the next 6 months to firm up the warnings
and errors we get from incompatible ABI issues with float128
and double-double will help the downstream distros handle this
transition more smoothly.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.
More information about the Binutils mailing list