Peter Bergner bergner@vnet.ibm.com
Tue May 8 01:50:00 GMT 2018

• Previous message (by thread): [PATCH, ppc] Simplify VLE handling in print_insn_powerpc()
• Next message (by thread): Correct powerpc spe opcode lookup
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On 5/7/18 6:47 PM, Alan Modra wrote:
> I don't think it matters either way, but the code is simpler without
> vle_status so I'd prefer that you do return the second 2-byte read
> status.  OK with that change

Done.


>> -	insn_is_short = PPC_OP_SE_VLE(opcode->mask);
>> +      if (opcode != NULL && PPC_OP_SE_VLE(opcode->mask))
> 
> and since you're editing the code, please fix the formatting here.

Ah, thanks for spotting the extra space.  Fixed and committed.  Thanks!

Peter

---

• Previous message (by thread): [PATCH, ppc] Simplify VLE handling in print_insn_powerpc()
• Next message (by thread): Correct powerpc spe opcode lookup
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list