Home Original page

-Wstringop-truncation warnings

H.J. Lu hjl.tools@gmail.com
Wed May 23 17:18:00 GMT 2018 
On Fri, May 4, 2018 at 2:32 AM, Alan Modra <amodra@gmail.com> wrote:
> This patch is aimed at silencing gcc8 -Wstringop-truncation warnings.
>
> Unfortunately adding  __attribute__ ((__nonstring)) doesn't work in a
> number of the places patched here, (see
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643) so if you have
> recent glibc headers installed you'll need to configure binutils with
> --disable-werror to compile using gcc8 or gcc9.
>
> include/
>         * ansidecl.h: Import from gcc.
>         * coff/internal.h (struct internal_scnhdr): Add ATTRIBUTE_NONSTRING
>         to s_name.
>         (struct internal_syment): Add ATTRIBUTE_NONSTRING to _n_name.
> bfd/
>         * elf-linux-core.h (struct elf_external_linux_prpsinfo32_ugid32),
>         (struct elf_external_linux_prpsinfo32_ugid16),
>         (struct elf_external_linux_prpsinfo64_ugid32),
>         (struct elf_external_linux_prpsinfo64_ugid16): Add ATTRIBUTE_NONSTRING
>         to pr_fname and pr_psargs fields.  Remove GCC diagnostic pragmas.
>         Move comment to..
>         * elf.c (elfcore_write_prpsinfo): ..here.  Indent nested preprocessor
>         directives.
>         * elf32-arm.c (elf32_arm_nabi_write_core_note): Add ATTRIBUTE_NONSTRING
>         to data.
>         * elf32-ppc.c (ppc_elf_write_core_note): Likewise.
>         * elf32-s390.c (elf_s390_write_core_note): Likewise.
>         * elf64-s390.c (elf_s390_write_core_note): Likewise.
>         * elfxx-aarch64.c (_bfd_aarch64_elf_write_core_note): Likewise.
>         * elf64-x86-64.c (elf_x86_64_write_core_note): Add GCC diagnostic
>         pragmas.
>         * peXXigen.c (_bfd_XXi_swap_scnhdr_out): Use strnlen to avoid
>         false positive gcc-8 warning.
> gas/
>         * config/obj-evax.c (shorten_identifier): Use memcpy in place
>         of strncpy.
>         * config/obj-macho.c (obj_mach_o_make_or_get_sect): Ensure
>         segname and sectname fields are NUL terminated.
>

I checked in this one.

-- 
H.J.
--
>From 9ef6d1e31f380349c8f329d1adb47ee53ec1f6c2 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 23 May 2018 10:15:11 -0700
Subject: [PATCH] Add ATTRIBUTE_NONSTRING to ppc64_elf_write_core_note

This patch silences gcc8 -Wstringop-truncation warnings.

* elf64-ppc.c (ppc64_elf_write_core_note): Add ATTRIBUTE_NONSTRING
to data.
---
 bfd/ChangeLog   | 5 +++++
 bfd/elf64-ppc.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1f6a85f7e0..f086ad59c1 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-05-23  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * elf64-ppc.c (ppc64_elf_write_core_note): Add ATTRIBUTE_NONSTRING
+ to data.
+
 2018-05-22  Alan Modra  <amodra@gmail.com>

  PR 23207
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index b166558945..7f7a8f777e 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -3035,7 +3035,7 @@ ppc64_elf_write_core_note (bfd *abfd, char *buf,
int *bufsiz, int note_type,

     case NT_PRPSINFO:
       {
- char data[136];
+ char data[136] ATTRIBUTE_NONSTRING;
  va_list ap;

  va_start (ap, note_type);
-- 
2.17.0
More information about the Binutils mailing list