Nick Clifton nickc@redhat.com
Mon Nov 5 17:22:00 GMT 2018

• Previous message (by thread): [PATCH] x86: Disable GOT relaxation with data prefix
• Next message (by thread): [PATCH 1/2] Fix pe timestamp comment
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Bernhard,

> diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c
> index e0b494a289..bfa21166ae 100644
> --- a/bfd/peXXigen.c
> +++ b/bfd/peXXigen.c
> @@ -877,7 +877,8 @@ _bfd_XXi_only_swap_filehdr_out (bfd * abfd, void * in, void * out)
>     H_PUT_16 (abfd, filehdr_in->f_magic, filehdr_out->f_magic);
>     H_PUT_16 (abfd, filehdr_in->f_nscns, filehdr_out->f_nscns);
>   
> -  /* Only use a real timestamp if the option was chosen.  */
> +  /* Use a real timestamp by default, unless the no-insert-timestamp
> +     option was chosen.  */
>     if ((pe_data (abfd)->insert_timestamp))
>       H_PUT_32 (abfd, time (0), filehdr_out->f_timdat);
>     else

This specific patch is OK, although it does need a ChangeLog entry
to go with it.  I can create one if you wish, but if you are going
to apply the patch yourself then please post the changelog update
to this list at the same time.

Cheers
   Nick

---

• Previous message (by thread): [PATCH] x86: Disable GOT relaxation with data prefix
• Next message (by thread): [PATCH 1/2] Fix pe timestamp comment
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list