tgingold@free.fr tgingold@free.fr
Tue Nov 6 14:25:00 GMT 2018

• Previous message (by thread): [PATCH 1/6] mach-o: Don't split version into a few fields
• Next message (by thread): [PATCH 3/6] mach-o: Print LC_VERSION_MIN_WATCHOS
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hello,

I am ok with your whole patchset, but:

> +static void
> +printf_version (uint32_t version) {
> +  uint32_t maj, min, upd;
> +  maj = (version >> 16) & 0xffff;
> +  min = (version >> 8) & 0xff;
> +  upd = version & 0xff;
> +  printf ("%u.%u.%u", maj, min, upd);
> +}

this doesn't follow the GNU code style.  The '{' must be on a new line.

I haven't upgraded to latest Darwin, so I haven't checked the code.

Thanks,
Tristan.

---

• Previous message (by thread): [PATCH 1/6] mach-o: Don't split version into a few fields
• Next message (by thread): [PATCH 3/6] mach-o: Print LC_VERSION_MIN_WATCHOS
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list