Jose E. Marchesi jose.marchesi@oracle.com
Tue Sep 4 18:49:00 GMT 2018

• Previous message (by thread): [SPARC, COMMITTED 0/2] Fix emitting errors on invalid relocations
• Next message (by thread): [SPARC, COMMITTED 1/2] bfd, sparc: issue an error when reading relocations with invalid symbol references.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

From: jose.marchesi@oracle.com

This patch avoids a duplicated error message when an invalid
relocation number is read from an object file in sparc-* ELF targets:

$ strip -g test.o
strip: test.o: unsupported relocation type 0xd7
strip: test.o: unsupported relocation type 0xd7
strip: test.o: bad value

Tested in x86_64-linux-gnu, sparc64-linux-gnu and sparc-linux-gnu
targets.

bfd/ChangeLog:

2018-09-04  Jose E. Marchesi  <jose.marchesi@oracle.com>

	* elfxx-sparc.c (_bfd_sparc_elf_info_to_howto): Do not issue an
	error when an invalid relocation is passed;  this is already done
	by `_bfd_sparc_elf_info_to_howto_ptr'.
---
 bfd/ChangeLog     | 6 ++++++
 bfd/elfxx-sparc.c | 2 --
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 22837e0f0e..bc1cb15a8f 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,11 @@
 2018-09-04  Jose E. Marchesi  <jose.marchesi@oracle.com>
 
+	* elfxx-sparc.c (_bfd_sparc_elf_info_to_howto): Do not issue an
+	error when an invalid relocation is passed;  this is already done
+	by `_bfd_sparc_elf_info_to_howto_ptr'.
+
+2018-09-04  Jose E. Marchesi  <jose.marchesi@oracle.com>
+
 	* elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Issue an
 	error when an invalid symbol index is retrieved in ELF64_R_SYM of
 	a relocation seen in an input file.
diff --git a/bfd/elfxx-sparc.c b/bfd/elfxx-sparc.c
index 81812afc5a..bf143c400f 100644
--- a/bfd/elfxx-sparc.c
+++ b/bfd/elfxx-sparc.c
@@ -658,8 +658,6 @@ _bfd_sparc_elf_info_to_howto (bfd *abfd, arelent *cache_ptr,
 
   if ((cache_ptr->howto = _bfd_sparc_elf_info_to_howto_ptr (abfd, r_type)) == NULL)
     {
-      _bfd_error_handler (_("%pB: unsupported relocation type %#x"),
-			  abfd, r_type);
       bfd_set_error (bfd_error_bad_value);
       return FALSE;
     }
-- 
2.11.0

---

• Previous message (by thread): [SPARC, COMMITTED 0/2] Fix emitting errors on invalid relocations
• Next message (by thread): [SPARC, COMMITTED 1/2] bfd, sparc: issue an error when reading relocations with invalid symbol references.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list