Home Original page

[PATCH][Binutils][AArch64] Fix bug in warning filtering.

Tamar Christina tamar.christina@arm.com
Thu Sep 13 14:45:00 GMT 2018 
Hi All,

This fixes a small bug with the warning filtering code, which when a line has
generated a warning and a template decode error (due to the way templates are
resolved) which would not have been emitted and warnings are being suppressed
with -W it would erroneously emit the error.

I have no testcase for this because the only places we generate warnings during
encoding/decoding now is using msr/mrs and system registers.  They don't have a
template that would trigger this.

However an upcoming patch series will have tests in it which would expose this bug.

build on native hardware and regtested on
  aarch64-none-elf, aarch64-none-elf (32 bit host),
  aarch64-none-linux-gnu, aarch64_be-none-linux-gnu

Cross-compiled and regtested on
  aarch64-none-linux-gnu, aarch64_be-none-linux-gnu

and no issues.

Ok for master? and for backport to binutils-2.31?

Thanks,
Tamar

gas/ChangeLog:

2018-09-13  Tamar Christina  <tamar.christina@arm.com>

	* config/tc-aarch64.c (output_operand_error_report): Apply filtering to
	current instead of head message.

-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rb9889.patch
Type: text/x-diff
Size: 696 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20180913/af9d655c/attachment.bin>
More information about the Binutils mailing list