Home Original page

[PATCH] gas: Pass max_bytes to TC_FRAG_INIT

H.J. Lu hjl.tools@gmail.com
Sun Feb 10 03:43:00 GMT 2019 
On Sat, Feb 9, 2019 at 6:01 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Sat, Feb 09, 2019 at 06:19:09AM -0800, H.J. Lu wrote:
> >       PR gas/24165
> >       * frags.c (frag_var_init): Support TC_FRAG_INIT_WITH_MAX_CHARS.
> >       * config/tc-i386.h (MAX_MEM_FOR_RS_ALIGN_CODE): Set to
> >       (alignment ? ((1 << alignment) - 1) : 1)
> >       (i386_tc_frag_data): Add max_bytes.
> >       (TC_FRAG_INIT): Renamed to ...
> >       (TC_FRAG_INIT2): This.  Track max_bytes.
> >       (HANDLE_ALIGN): Replace MAX_MEM_FOR_RS_ALIGN_CODE with
> >        fragP->tc_frag_data.max_bytes.
>
> The idea is good, but I think it would be better to just add another
> parameter to TC_FRAG_INIT and update target code rather than
> introducing TC_FRAG_INIT2.  I'll preapprove a patch to do that.  It's
> not a huge amount of work, and you'll be tidying ARM and AARCH64 which
> already sneak max_chars into their init_frag functions.
>

This is the patch I am checking in.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gas-Pass-max_bytes-to-TC_FRAG_INIT.patch
Type: application/x-patch
Size: 12209 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20190210/2c4a00e5/attachment.bin>
More information about the Binutils mailing list