Nick Alcock nick.alcock@oracle.com
Tue Jul 16 18:04:00 GMT 2019

• Previous message (by thread): [PATCH 18/19 REVIEW] bfd: new functions for getting strings out of a strtab
• Next message (by thread): [PATCH 07/19 REVIEW] binutils: objdump does not take --ctf-symbols or --ctf-strings options
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

This hoary old header defines things like MAX that users of libctf might
perfectly reasonably define themselves.

The CTF headers do not need it: move it into libctf/ctf-impl.h instead.

include/
	* ctf-api.h (includes): No longer include <sys/param.h>.
libctf/
	* ctf-impl.h (includes): Include <sys/param.h> here.
---
 include/ctf-api.h | 1 -
 libctf/ctf-impl.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/ctf-api.h b/include/ctf-api.h
index ac20551917..37a4d817fd 100644
--- a/include/ctf-api.h
+++ b/include/ctf-api.h
@@ -24,7 +24,6 @@
 #ifndef	_CTF_API_H
 #define	_CTF_API_H
 
-#include <sys/param.h>
 #include <sys/types.h>
 #include <ctf.h>
 #include <zlib.h>
diff --git a/libctf/ctf-impl.h b/libctf/ctf-impl.h
index 0b72866b30..683f395160 100644
--- a/libctf/ctf-impl.h
+++ b/libctf/ctf-impl.h
@@ -22,6 +22,7 @@
 
 #include "config.h"
 #include <errno.h>
+#include <sys/param.h>
 #include "ctf-decls.h"
 #include <ctf-api.h>
 #include <sys/types.h>
-- 
2.22.0.238.g049a27acdc

---

• Previous message (by thread): [PATCH 18/19 REVIEW] bfd: new functions for getting strings out of a strtab
• Next message (by thread): [PATCH 07/19 REVIEW] binutils: objdump does not take --ctf-symbols or --ctf-strings options
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list