Committing patches for other people
Eric Christopher
echristo@gmail.com
Wed Feb 19 23:35:00 GMT 2020
More information about the Binutils mailing list
Wed Feb 19 23:35:00 GMT 2020
- Previous message (by thread): Committing patches for other people
- Next message (by thread): [PATCH 2/2] Fix several mix up between octets and bytes in ELF program headers
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Ah yes that's a very good point. On Wed, Feb 19, 2020, 2:55 PM Alan Modra <amodra@gmail.com> wrote: > On Wed, Feb 19, 2020 at 01:58:20PM -0800, Eric Christopher wrote: > > I've gone ahead and committed this for Jordan. > > OK, but I'll note that when not using "git am" to commit other > people's patches you should take steps to properly attribute > authorship. > git commit --amend --author="Joe Bloe <joe@somewhere.net>" > > As it is, "git blame" shows > 741cb83912f (Eric Christopher 2020-02-19 13:55:25 -0800 > for objdump.c lines changed by Jordan's patch. > > None of this matters very much at the moment, but if we are to move > away from ChangeLogs then we will need to learn better habits. > > -- > Alan Modra > Australia Development Lab, IBM >
- Previous message (by thread): Committing patches for other people
- Next message (by thread): [PATCH 2/2] Fix several mix up between octets and bytes in ELF program headers
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Binutils mailing list